core: polishing and docs for ServerBuilder API #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should signify that the binding is not yet done when the method is called but only later when the source is materialized.
akka-ci
added
validating
…nto server-builder-docs
akka-ci
added
needs-attention
|
Test PASSed. |
raboof
approved these changes
Jul 21, 2020
| */ | ||
| def bind(): Source[IncomingConnection, CompletionStage[ServerBinding]] | ||
| def connectionSource(): Source[IncomingConnection, CompletionStage[ServerBinding]] |
There was a problem hiding this comment.
We also call it Tcp.bind() in Akka, but I agree something like this is better.
Just connections or source/asSource would work for me as well, this is 👍 too.
There was a problem hiding this comment.
Just
connectionsorsource/asSourcewould work for me as well, this is +1 too.
All good suggestions, but lets keep connectionSource as I like the extra verbosity for that particular method.
| Http().newServerAt("127.0.0.1", 443).enableHttps(https).bindFlow(commonRoutes) | ||
| Http().newServerAt("127.0.0.1", 80).bindFlow(commonRoutes) | ||
| Http().newServerAt("127.0.0.1", 443).enableHttps(https).bind(commonRoutes) | ||
| Http().newServerAt("127.0.0.1", 80).bind(commonRoutes) |
There was a problem hiding this comment.
👍 weird that we had bindFlow here before
There was a problem hiding this comment.
I think that might have been missed by scalafix for some reason.
Co-authored-by: Arnout Engelen <github@bzzt.net>
akka-ci
added
validating
|
Test PASSed. |
jrudolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind()toconnectionSourceto make it clear that calling the method will not immediately create a binding and also to avoid overloadingbind()(which became awkward in docs)Http().bindXYZusages