Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run aspell on the documentation #407

Merged
merged 2 commits into from
Oct 21, 2016
Merged

Run aspell on the documentation #407

merged 2 commits into from
Oct 21, 2016

Conversation

jonas
Copy link
Member

@jonas jonas commented Oct 18, 2016

No description provided.

@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Oct 18, 2016
jonas
jonas commented Oct 18, 2016
View reviewed changes
docs/src/main/paradox/java/http/implications-of-streaming-http-entity.md
@@ -39,7 +39,7 @@ eagerly consume the entity and make it available in memory:
### Discarding the HTTP Response Entity (Client)

Sometimes when calling HTTP services we do not care about their response payload (e.g. all we care about is the response code),
yet as explained above entity still has to be consumed in some way, otherwise we'll be exherting back-pressure on the
yet as explained above entity still has to be consumed in some way, otherwise we'll be exerting back-pressure on the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct

@ktoso
Copy link
Member

ktoso commented Oct 18, 2016 •
edited
Loading

Did you use US or UK english? We tend to use US english (though I find that weird being UK language biased ;-))

@ktoso
Copy link
Member

ktoso commented Oct 18, 2016

Awesome idea btw

jonas
jonas commented Oct 18, 2016
View reviewed changes
docs/src/main/paradox/scala/http/implications-of-streaming-http-entity.md
@@ -39,7 +39,7 @@ eagerly consume the entity and make it available in memory:
### Discarding the HTTP Response Entity (Client)

Sometimes when calling HTTP services we do not care about their response payload (e.g. all we care about is the response code),
yet as explained above entity still has to be consumed in some way, otherwise we'll be exherting back-pressure on the
yet as explained above entity still has to be consumed in some way, otherwise we'll be exerting back-pressure on the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... also found here

@jonas
Copy link
Member Author

jonas commented Oct 18, 2016 •
edited
Loading

I used en_US, but did not convert British to American spelling: specialised => specialized etc.

@jonas
Copy link
Member Author

jonas commented Oct 18, 2016

If I get time I might try to come up with some scripts to run aspell or hunspell with a pregenerated dictionary to reduce noise from code snippets etc.

@akka-ci akka-ci added the needs-attention Indicates a PR validation failure (set by CI infrastructure) label Oct 18, 2016
@akka-ci
Copy link

akka-ci commented Oct 18, 2016

Test FAILed.

@akka-ci akka-ci removed the validating PR that is currently being validated by Jenkins label Oct 18, 2016
@jonas
Copy link
Member Author

jonas commented Oct 18, 2016

Failure is same as #333 which was supposed to be resolved by #403. Reopen?

@ktoso
Copy link
Member

ktoso commented Oct 18, 2016

When did you branch off this PR? Can you rebase just to be sure that fix is included here?

@jonas
Copy link
Member Author

jonas commented Oct 18, 2016

I branched on top of current master

> git branch --contains 3f807a71182378effd0ce89bb2ad68ed8934f67f
  master
* spell-checking
> git log --graph -n 5 --oneline
* 30ce2ff Run aspell on the documentation
* 66adf84 fix references to http-experimental (#406)
* b0300b3 dont publish tests, in proper style (#404)
* c258990 Put akka-stream-testkit in test configuration (#401) (#402)
* 3f807a7 =htp #333 increase timeout, 1 second is too little on jenkins (#403)

@jonas
Copy link
Member Author

jonas commented Oct 18, 2016 •
edited
Loading

Rechecked and it is in fact a new failure for the test case with seven parameters.

https://jenkins.akka.io:8498/job/pr-validator-akka-http/160/consoleFull

[info] - should properly bind and handle a server with a flow (with seven parameters) *** FAILED ***
[info]   java.util.concurrent.ExecutionException: akka.stream.StreamTcpException: Tcp command [Connect(localhost:42995,None,List(),Some(10 seconds),true)] failed
[info]   at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
[info]   at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1907)
[info]   at scala.concurrent.java8.FuturesConvertersImpl$CF.scala$concurrent$java8$FuturesConvertersImpl$CF$$super$get(FutureConvertersImpl.scala:84)
[info]   at scala.concurrent.java8.FuturesConvertersImpl$CF$$anonfun$get$2.apply(FutureConvertersImpl.scala:84)
[info]   at scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:53)
[info]   at scala.concurrent.package$.blocking(package.scala:123)
[info]   at scala.concurrent.java8.FuturesConvertersImpl$CF.get(FutureConvertersImpl.scala:84)
[info]   at akka.http.javadsl.HttpExtensionApiSpec.akka$http$javadsl$HttpExtensionApiSpec$$waitFor(HttpExtensionApiSpec.scala:474)
[info]   at akka.http.javadsl.HttpExtensionApiSpec$$anonfun$1$$anonfun$apply$mcV$sp$7.apply(HttpExtensionApiSpec.scala:155)
[info]   at akka.http.javadsl.HttpExtensionApiSpec$$anonfun$1$$anonfun$apply$mcV$sp$7.apply(HttpExtensionApiSpec.scala:145)
[info]   ...
[info]   Cause: akka.stream.StreamTcpException: Tcp command [Connect(localhost:42995,None,List(),Some(10 seconds),true)] failed

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Oct 18, 2016
@akka-ci
Copy link

akka-ci commented Oct 18, 2016

Test PASSed.

@jonas
Copy link
Member Author

jonas commented Oct 19, 2016

Could the test failure be caused by a race condition in how TestUtil finds available ports and the test binds to it? Let me know if I should create an issue.

@ktoso
Copy link
Member

ktoso commented Oct 21, 2016

We'll work on fleaky tests separately from this issue, I'll open tickets for each failure.

@ktoso
Copy link
Member

ktoso commented Oct 21, 2016

LGTM, thanks!

@ktoso ktoso merged commit 429c586 into akka:master Oct 21, 2016
@jonas jonas deleted the spell-checking branch October 21, 2016 15:44
jedrekn pushed a commit to jedrekn/akka-http that referenced this pull request Nov 17, 2016
@jonas @ktoso
Run aspell on the documentation (akka#407)
7ad5345 
* Run aspell on the documentation

* Spell check README and CONTRIBUTING docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso left review comments

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas @ktoso @akka-ci