Match path maps in order of longest matching key prefix (#394) #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
|
Failed test is #493 |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
|
LGTM |
|
PLS BUILD |
akka-ci
added
validating
|
Test PASSed. |
aruediger
reviewed
Jan 5, 2017
| * | ||
| * @group pathmatcherimpl | ||
| */ | ||
| implicit def _valueMap2PathMatcher[T](valueMap: Map[String, T]): PathMatcher1[T] = | ||
| if (valueMap.isEmpty) PathMatchers.nothingMatcher | ||
| else valueMap.map { case (prefix, value) ⇒ _stringExtractionPair2PathMatcher((prefix, value)) }.reduceLeft(_ | _) | ||
| else valueMap.toSeq.sortWith(_._1 > _._1).map(_stringExtractionPair2PathMatcher).reduceLeft(_ | _) |
There was a problem hiding this comment.
checked that, actually would fail hm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394 by ensuring order of the provided mappings instead of leaving it up to the undefined order provided by the map implementation.
It might be a bit overkill to include all of the test cases created by @gosubpl but I included them for completeness and to test with
ListMap.