FTP Homogenize model #407
FTP Homogenize model #407
Conversation
|
It seems that #386 might have destabilized Travis construction |
|
I think moving these to the top level makes a lot of sense, nice. That 'fluent API' seems nice, too - I'd be in favour of adding it for the other configuration classes as well. Any reason not to want it? |
juanjovazquez
force-pushed
the
395-ftp-homogenize-model
branch
from
92079a9
to
0b4d38b
Compare
juanjovazquez
force-pushed
the
395-ftp-homogenize-model
branch
from
0b4d38b
to
612b022
Compare
|
@raboof No reason at all. In fact, I've already applied the fluent constructors to the other settings. Thanks. This PR would be ready for merging if you agree. |
| @@ -71,7 +71,7 @@ trait CommonFtpStageSpec extends BaseSpec with Eventually { | |||
| implicit val system = getSystem | |||
| implicit val mat = getMaterializer | |||
| implicit val defaultPatience = | |||
| PatienceConfig(timeout = Span(10, Seconds), interval = Span(300, Millis)) | |||
| PatienceConfig(timeout = Span(30, Seconds), interval = Span(600, Millis)) | |||
There was a problem hiding this comment.
Might be wise, I've seen timeouts as well. Are those actually to be expected? Do we know why those are so slow?
There was a problem hiding this comment.
@raboof I don't know why they're so slow on Travis. Of course, it has to do with the fact that these tests need to start and stop FTP servers but we should do fine tuning on these instances in order to configure the servers properly for working on Travis builds.
There was a problem hiding this comment.
Actually I've seen tests be quite slow on my local machine at times as well - but haven't taken the time to really dig into that yet.
This is a proposal to make the model of the FTP component more homogeneous. It remains to be decided if we want to replicate in
FTPandFTPsthe fluent API that has been defined insFTP, especially for Java use. Feedback is appreciated.Closes #395