Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies to run TcpServerBM from command line #280

Merged
merged 7 commits into from
Jun 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allows you to include transitive dependencies implicitly in the shade…
…d JAR file
  • Loading branch information
Akram Yakubov committed Jun 19, 2023
commit 90722fefde99a4ae9e2eb0c96ee4a91a61bd78b7
1 change: 1 addition & 0 deletions runtime/binding-tcp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@
<include>com.github.biboudis:jmh-profilers</include>
</includes>
</artifactSet>
<includeDependencies>true</includeDependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this picks up dependencies transitively, can we trim the list above to no longer need to include any engine dependencies explicitly?

That would be better to implicitly keep the engine dependencies in sync.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, suggest moving this configuration to top level pom.xml instead, with the rest of the default configuration for shade plugin as each project will need the same configuration.

</configuration>
</plugin>
</plugins>
Expand Down