Fix message fragmentation in sse-kafka and flow control in kafka merge #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
changed the title
jfallows
requested changes
Jun 23, 2023
| @@ -806,6 +812,8 @@ private void doKafkaWindow( | |||
|
|
|||
| doWindow(kafka, originId, routedId, replyId, replySeq, replyAck, replyMax, | |||
| traceId, authorization, budgetId, padding, minimum, capabilities); | |||
|
|
|||
| System.out.println(String.format("Sse budget doKafkaWindow %d", replyMax - (int)(replySeq - replyAck))); | |||
There was a problem hiding this comment.
Please remove this System.out before we can merge.
| @@ -85,7 +85,7 @@ public class EngineConfiguration extends Configuration | |||
| EngineConfiguration::decodeHostResolver, EngineConfiguration::defaultHostResolver); | |||
| ENGINE_BUDGETS_BUFFER_CAPACITY = config.property("budgets.buffer.capacity", 1024 * 1024); | |||
| ENGINE_LOAD_BUFFER_CAPACITY = config.property("load.buffer.capacity", 1024 * 8); | |||
| ENGINE_STREAMS_BUFFER_CAPACITY = config.property("streams.buffer.capacity", 1024 * 1024); | |||
| ENGINE_STREAMS_BUFFER_CAPACITY = config.property("streams.buffer.capacity", 2097152); | |||
There was a problem hiding this comment.
Please don't change the defaults if avoidable.
If a specific IT requires a different value for this configuration then please override it for just that IT.
| @@ -397,6 +397,7 @@ public KafkaFilterBuilder<T> header( | |||
| String name, | |||
| String value) | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
Please revert this whitespace change.
jfallows
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorrect flow control credit when large message in flight was causing flow control budget to be exceeded when near the flow control limit.
Fixes #281