Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm configs so appVersion is used as the tag #489

Merged

Conversation

vordimous
Copy link
Contributor

Description

The default values.yaml doesn't need to override the desired image version and can be removed. This will enable a 1-1 relationship between the chartVersion and the appVersion that is already being set in the pom:

 <configuration>
          <chartDirectory>src/main/helm</chartDirectory>
          <chartVersion>${project.version}</chartVersion>
          <appVersion>${project.version}</appVersion>
          ...

The repository is the only unique value we need to default based on the deployment.yaml. Users will be able to overwrite these values in their own values.yaml:

 image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

Fixes #487

@vordimous vordimous linked an issue Oct 3, 2023 that may be closed by this pull request
@vordimous vordimous changed the title remove values defaults so appVersion is used as the tag update helm configs so appVersion is used as the tag Oct 3, 2023
@jfallows jfallows marked this pull request as ready for review October 3, 2023 19:34
@jfallows jfallows merged commit 6dc771b into develop Oct 3, 2023
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 1-1 helm chart versioning strategy
3 participants