Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action #78

Merged
merged 15 commits into from
Jun 17, 2022
Merged

Fix github action #78

merged 15 commits into from
Jun 17, 2022

Conversation

akrambek
Copy link
Contributor

@akrambek akrambek commented Jun 10, 2022

Fix #23

@akrambek akrambek changed the title Test github action Fix github action Jun 16, 2022
@@ -65,6 +65,7 @@ public void shouldSendAndReceiveData() throws Exception
k3po.finish();

EngineStats stats = engine.stats("test", "net0");
java.lang.invoke.VarHandle.fullFence();
Copy link
Contributor

@jfallows jfallows Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use import static java.lang.invoke.VarHandle.fullFence and then call fullFence() here instead.

Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also search for all other ITs using EngineStats and add the same call to fullFence() there too.

jfallows
jfallows previously approved these changes Jun 17, 2022
@jfallows jfallows merged commit f2a1ec9 into aklivity:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate GitHub Actions build inconsistencies
2 participants