Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding commons-networking #925

Merged
merged 3 commits into from
May 25, 2021
Merged

Adding commons-networking #925

merged 3 commits into from
May 25, 2021

Conversation

liran2000
Copy link
Contributor

@liran2000 liran2000 commented Feb 21, 2021

Adding commons-networking

Features:

  • SSE (Server-sent Events) client

Simple SSE client almost without any dependencies, did not found anything similar online, and not here in this list.

It is used in developments in a similar version.

As it is new and similar implementation not found, it is currently still cannot be widely recommended.

Note: I am the author of this SSE client.

@akullpp
Copy link
Owner

akullpp commented Mar 1, 2021

I'll keep this open for a while. I think it's not ideal to have the SSE client and the GNMI utils in the same project and probably should be split up to two separate modules.

@liran2000
Copy link
Contributor Author

liran2000 commented Mar 1, 2021 via email

@liran2000
Copy link
Contributor Author

By your suggestion, I updated the PR changes to contain only the SSE client, and the link is referring only to the specific module of SSE client.

@liran2000
Copy link
Contributor Author

@akullpp can you merge it ? any concern ?

This is updated just for SSE Client module.

@akullpp akullpp merged commit b94df94 into akullpp:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants