Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/context menu trigger #1139

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Feat/context menu trigger #1139

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
adca504
Feat/noop trigger (#1133)
nnixaa Jan 8, 2019
c823cc2
feat(tooltip): add new `nbTooltipTrigger` parameter
nnixaa Jan 8, 2019
e4f45ca
Merge branch 'master' into feat/tooltip-trigger
nnixaa Jan 8, 2019
7f2f873
fix(trigger): fix document error
nnixaa Jan 9, 2019
af35dcf
feat(tooltip): add new `nbTooltipTrigger` parameter
nnixaa Jan 8, 2019
44e348a
feat(context-menu): add `nbContextMenuTrigger` parameter
nnixaa Jan 8, 2019
0555a3d
Merge branch 'master' into feat/context-menu-trigger
nnixaa Jan 9, 2019
4243091
fix(tooltip): fix messages
nnixaa Jan 9, 2019
30037e5
fix(overlay): remove document
nnixaa Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(tooltip): add new nbTooltipTrigger parameter
  • Loading branch information
@nnixaa
nnixaa committed Jan 9, 2019
commit af35dcf0b296184f44e0ed8766e1283d53b7fbaa
2 changes: 1 addition & 1 deletion src/framework/theme/components/cdk/overlay/overlay-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export class NbTriggerStrategyBuilderService {
protected _container: () => ComponentRef<any>;
protected _trigger: NbTrigger;

constructor(@Inject(NB_DOCUMENT) protected _document) {
constructor(@Inject(NB_DOCUMENT) protected _document: Document) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we'll not have any issues with the Document token in aot mode?

}

trigger(trigger: NbTrigger): this {
Expand Down