feat(layout): Eva style #1368
Merged
feat(layout): Eva style #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Following theme properties were renamed: header-font-family -> header-text-font-family header-font-size -> header-text-font-size header-line-height -> header-text-line-height header-fg -> header-text-color header-bg -> header-background-color layout-font-family -> layout-text-font-family layout-font-size -> layout-text-font-size layout-line-height -> layout-text-line-height layout-fg -> layout-text-color layout-bg -> layout-background-color layout-window-mode-bg -> layout-window-mode-background-color footer-fg -> footer-text-color footer-fg-highlight -> footer-text-highlight-color footer-bg -> footer-background-color footer-separator -> footer-divider-color
nnixaa
requested changes
Apr 9, 2019
There was a problem hiding this comment.
also http://localhost:4200/#/layout/layout-subheader.component don't work because of not loaded icons
| padding: nb-theme(footer-padding); | ||
| background: nb-theme(footer-bg); | ||
| color: nb-theme(footer-fg); | ||
| background-color: nb-theme(footer-background-color); | ||
| border-top: 1px solid nb-theme(footer-separator); |
There was a problem hiding this comment.
there is no such variable as footer-separator
Fixed in 4983d0f |
nnixaa
approved these changes
Apr 10, 2019
yggg
added a commit
that referenced
this pull request
Apr 17, 2019
BREAKING CHANGE: Following theme properties were renamed: header-font-family -> header-text-font-family header-font-size -> header-text-font-size header-line-height -> header-text-line-height header-fg -> header-text-color header-bg -> header-background-color layout-font-family -> layout-text-font-family layout-font-size -> layout-text-font-size layout-line-height -> layout-text-line-height layout-fg -> layout-text-color layout-bg -> layout-background-color layout-window-mode-bg -> layout-window-mode-background-color footer-fg -> footer-text-color footer-fg-highlight -> footer-text-highlight-color footer-bg -> footer-background-color footer-separator -> footer-divider-color
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Following theme properties were renamed: header-font-family -> header-text-font-family header-font-size -> header-text-font-size header-line-height -> header-text-line-height header-fg -> header-text-color header-bg -> header-background-color layout-font-family -> layout-text-font-family layout-font-size -> layout-text-font-size layout-line-height -> layout-text-line-height layout-fg -> layout-text-color layout-bg -> layout-background-color layout-window-mode-bg -> layout-window-mode-background-color footer-fg -> footer-text-color footer-fg-highlight -> footer-text-highlight-color footer-bg -> footer-background-color footer-separator -> footer-divider-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
Following theme properties were renamed:
header-font-family -> header-text-font-family
header-font-size -> header-text-font-size
header-line-height -> header-text-line-height
header-fg -> header-text-color
header-bg -> header-background-color
layout-font-family -> layout-text-font-family
layout-font-size -> layout-text-font-size
layout-line-height -> layout-text-line-height
layout-fg -> layout-text-color
layout-bg -> layout-background-color
layout-window-mode-bg -> layout-window-mode-background-color
footer-fg -> footer-text-color
footer-fg-highlight -> footer-text-highlight-color
footer-bg -> footer-background-color
footer-separator -> footer-divider-color