fix(theme): finalize themes with design system #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
suggested changes
May 22, 2019
yggg
suggested changes
May 22, 2019
|
we also need to remove |
Fixes double click on mobile
Also decrease form control sizes to large
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 83.27% 83.27% -0.01%
==========================================
Files 230 230
Lines 7487 7486 -1
Branches 659 659
==========================================
- Hits 6235 6234 -1
Misses 1061 1061
Partials 191 191
|
yggg
approved these changes
May 23, 2019
nnixaa
changed the title
yggg
pushed a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGES: The following sass mixins are removed: `nb-radial-gradient`, `nb-right-gradient`. Theme variables changes: **renamed:** font-main -> font-family-primary font-secondary -> font-family-secondary radius -> border-radius color-bg -> background-basic-color-1, color-bg-active -> background-basic-color-2, color-fg -> text-basic-color, color-fg-heading -> text-basic-color, color-fg-text -> text-hint-color, separator -> divider-color scrollbar-fg -> scrollbar-color, scrollbar-bg -> scrollbar-background-color, scrollbar-thumb-radius -> scrollbar-width **removed:** color-fg-highlight: #40dc7e, font-weight-thin: 200, font-weight-light: 300, font-weight-normal: 400, font-weight-bolder: 500, font-weight-bold: 600, font-weight-ultra-bold: 800, base-font-size: 16px, font-size-xlg: 1.25rem, font-size-lg: 1.125rem, font-size: 1rem, font-size-sm: 0.875rem, font-size-xs: 0.75rem, padding: 1.25rem, margin: 1.5rem, line-height: 1.25, separator: #ebeef2, social-color-facebook: #3b5998, social-color-twitter: #55acee, social-color-google: #dd4b39, social-color-linkedin: #0177b5, social-color-github: #6b6b6b, social-color-stackoverflow: #2f96e8, social-color-dribble: #f26798, social-color-behance: #0093fa, radial-gradient: none, linear-gradient: none,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
nb-radial-gradient,nb-right-gradientrenamed:
font-main -> font-family-primary
font-secondary -> font-family-secondary
radius -> border-radius
color-bg -> background-basic-color-1,
color-bg-active -> background-basic-color-2,
color-fg -> text-basic-color,
color-fg-heading -> text-basic-color,
color-fg-text -> text-hint-color,
separator -> divider-color
scrollbar-fg -> scrollbar-color,
scrollbar-bg -> scrollbar-background-color,
scrollbar-thumb-radius -> scrollbar-width
removed:
color-fg-highlight: #40dc7e,
font-weight-thin: 200,
font-weight-light: 300,
font-weight-normal: 400,
font-weight-bolder: 500,
font-weight-bold: 600,
font-weight-ultra-bold: 800,
base-font-size: 16px,
font-size-xlg: 1.25rem,
font-size-lg: 1.125rem,
font-size: 1rem,
font-size-sm: 0.875rem,
font-size-xs: 0.75rem,
padding: 1.25rem,
margin: 1.5rem,
line-height: 1.25,
separator: #ebeef2,// TODO: move to constants
social-color-facebook: #3b5998,
social-color-twitter: #55acee,
social-color-google: #dd4b39,
social-color-linkedin: #0177b5,
social-color-github: #6b6b6b,
social-color-stackoverflow: #2f96e8,
social-color-dribble: #f26798,
social-color-behance: #0093fa,
radial-gradient: none,
linear-gradient: none,