feat(theme): ability to add custom statuses #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Empty string won't be converted to `basic` status anymore. Pass default `'basic'` instead.
BREAKING CHANGE: `NbComponentStatus` type replaced with `NbComponentOrCustomStatus` in following properties: `NbActionComponent.badgeStatus`, `NbBadge.status`, `NbBadgeComponent.status`, `NbButtonComponent.status`, `NbAlertComponent.status`, `NbCardComponent.status`, `NbChatFormComponent.status`, `NbChatComponent.status`, `NbCheckboxComponent.status`, `NbFormFieldControl.status$`, `NbFormControlState.status`, `NbInputDirective.status`, `NbInputDirective.status%`, `NbSelectComponent.status`, `NbSelectComponent.status$`, `NbIconConfig.status`, `NbIconComponent.status`, `NbProgressBarComponent.status`, `NbRadioComponent.status`, `NbRadioGroupComponent.status`, `NbSpinnerDirective.spinnerStatus`, `NbSpinnerComponent.status`, `NbTabComponent.badgeStatus`, `NbToastrConfig.status`, `NbToggleComponent.status`, `NbTooltipDirective.status`, `NbTooltipComponent.context.status`, `NbUserComponent.badgeStatus`. If you extended listed components replace `NbComponentStatus` in the property type with `NbComponentOrCustomStatus`. `NbBadgeComponent`, `NbButtonComponent`, `NbAlertComponent`, `NbCardComponent`, `NbChatComponent`, `NbCheckboxComponent`, `NbInputDirective`, `NbSelectComponent`, `NbIconComponent`, `NbProgressBarComponent`, `NbRadioComponent`, `NbSpinnerComponent`, `NbToastComponent`, `NbToggleComponent`, `NbTooltipComponent` constructors now require `NbStatusService` as a constructor parameter. If you extended listed components, inject `NbStatusService` and pass it to the base class.
yggg
added a commit
that referenced
this pull request
Dec 24, 2020
BREAKING CHANGE: Empty string won't be converted to `basic` status anymore. If you used to set `status` properties to `''` change it to `'basic'`. `NbComponentStatus` type replaced with `NbComponentOrCustomStatus` in following properties: `NbActionComponent.badgeStatus`, `NbBadge.status`, `NbBadgeComponent.status`, `NbButtonComponent.status`, `NbAlertComponent.status`, `NbCardComponent.status`, `NbChatFormComponent.status`, `NbChatComponent.status`, `NbCheckboxComponent.status`, `NbFormFieldControl.status$`, `NbFormControlState.status`, `NbInputDirective.status`, `NbInputDirective.status%`, `NbSelectComponent.status`, `NbSelectComponent.status$`, `NbIconConfig.status`, `NbIconComponent.status`, `NbProgressBarComponent.status`, `NbRadioComponent.status`, `NbRadioGroupComponent.status`, `NbSpinnerDirective.spinnerStatus`, `NbSpinnerComponent.status`, `NbTabComponent.badgeStatus`, `NbToastrConfig.status`, `NbToggleComponent.status`, `NbTooltipDirective.status`, `NbTooltipComponent.context.status`, `NbUserComponent.badgeStatus`. If you extended listed components replace `NbComponentStatus` in the property type with `NbComponentOrCustomStatus`. `NbBadgeComponent`, `NbButtonComponent`, `NbAlertComponent`, `NbCardComponent`, `NbChatComponent`, `NbCheckboxComponent`, `NbInputDirective`, `NbSelectComponent`, `NbIconComponent`, `NbProgressBarComponent`, `NbRadioComponent`, `NbSpinnerComponent`, `NbToastComponent`, `NbToggleComponent`, `NbTooltipComponent` constructors now require `NbStatusService` as a constructor parameter. If you extended listed components, inject `NbStatusService` and pass it to the base class. (cherry picked from commit 3b2e903)
|
Hi, reading the CHANGELOG I found this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
Empty string won't be converted to
basicstatus anymore. If you used to setstatusproperties to''change it to'basic'.NbComponentStatustype replaced withNbComponentOrCustomStatusin following properties:NbActionComponent.badgeStatus,NbBadge.status,NbBadgeComponent.status,NbButtonComponent.status,NbAlertComponent.status,NbCardComponent.status,NbChatFormComponent.status,NbChatComponent.status,NbCheckboxComponent.status,NbFormFieldControl.status$,NbFormControlState.status,NbInputDirective.status,NbInputDirective.status%,NbSelectComponent.status,NbSelectComponent.status$,NbIconConfig.status,NbIconComponent.status,NbProgressBarComponent.status,NbRadioComponent.status,NbRadioGroupComponent.status,NbSpinnerDirective.spinnerStatus,NbSpinnerComponent.status,NbTabComponent.badgeStatus,NbToastrConfig.status,NbToggleComponent.status,NbTooltipDirective.status,NbTooltipComponent.context.status,NbUserComponent.badgeStatus.If you extended listed components replace
NbComponentStatusin the property type withNbComponentOrCustomStatus.NbBadgeComponent,NbButtonComponent,NbAlertComponent,NbCardComponent,NbChatComponent,NbCheckboxComponent,NbInputDirective,NbSelectComponent,NbIconComponent,NbProgressBarComponent,NbRadioComponent,NbSpinnerComponent,NbToastComponent,NbToggleComponent,NbTooltipComponentconstructors now requireNbStatusServiceas a constructor parameter. If you extended listed components, injectNbStatusServiceand pass it to the base class.