Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): scroll into selected option on open #2859

Merged
merged 4 commits into from
Nov 8, 2021
Merged

fix(select): scroll into selected option on open #2859

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4307aa8
fix(select): show active option
evtkhvch Sep 7, 2021
783c1e0
fix(select): set active when position has changed
evtkhvch Sep 17, 2021
0c47284
Merge branch 'master' into 2348-fix-select-scroll
yggg Nov 8, 2021
cff1a72
Merge branch 'master' into 2348-fix-select-scroll
yggg Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(select): show active option
  • Loading branch information
@evtkhvch
evtkhvch committed Sep 7, 2021
commit 4307aa8486d63f07dc7cc0f156d4cf913a630928
2 changes: 1 addition & 1 deletion src/framework/theme/components/select/select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ export class NbSelectComponent implements OnChanges, AfterViewInit, AfterContent
show() {
if (this.isHidden) {
this.attachToOverlay();
this.setActiveOption();
setTimeout(() => this.setActiveOption())
this.cd.markForCheck();
}
}
Expand Down