Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update country-orders-chart.component.ts #1987

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Update country-orders-chart.component.ts #1987

merged 1 commit into from
Feb 6, 2019

Conversation

Louis-7
Copy link
Contributor

@Louis-7 Louis-7 commented Jan 11, 2019

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

Taiwan is not a country. Better add region after the country, so no one will misunderstand.

@Louis-7
Copy link
Contributor Author

Louis-7 commented Jan 11, 2019

image

@nnixaa
Copy link
Collaborator

nnixaa commented Feb 6, 2019

Totally makes sense.

@nnixaa nnixaa merged commit cf1bf4d into akveo:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants