[core] Try harder to send a valid port to the tracker #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main part of this change is that the actual IPEndPoint which the listnener has been bound to is not the sole source of the 'port' value which should be sent to the tracker. If the listener has been configured to bind to a specific port, but has (at the point in time when the announce is sent) not successfully bound to that port, the preferred port should be sent to the tracker. If the user has configured the listener to port '0' *and* the listener isn't running, then we have a problem as 'port' is a required parameter and must be sent. In this scenario, send an invalid port and the tracker should still return a list of peers to connect to.
alanmcgovern
deleted the
send-preferred-port-if-no-actual-port-when-announcing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this change is that the actual IPEndPoint which the listnener has been bound to is not the sole source of the 'port' value which should be sent to the tracker.
If the listener has been configured to bind to a specific port, but has (at the point in time when the announce is sent) not successfully bound to that port, the preferred port should be sent to the tracker.
If the user has configured the listener to port '0' and the listener isn't running, then we have a problem as 'port' is a required parameter and must be sent. In this scenario, send an invalid port and the tracker should still return a list of peers to connect to.
Fixes 1/2 of #613