Skip to content

Commit

Permalink
Use set comprehension syntax throughout
Browse files Browse the repository at this point in the history
  • Loading branch information
jdufresne committed Apr 30, 2017
1 parent 5c19840 commit 86f72cc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion piptools/resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def _resolve_one_round(self):

log.debug('')
log.debug('Finding the best candidates:')
best_matches = set(self.get_best_match(ireq) for ireq in constraints)
best_matches = {self.get_best_match(ireq) for ireq in constraints}

# Find the new set of secondary dependencies
log.debug('')
Expand Down
8 changes: 4 additions & 4 deletions tests/test_fake_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ def test_get_dependencies(from_line, repository):

ireq = from_line('Flask==0.10.1')
dependencies = repository.get_dependencies(ireq)
assert (set(str(req) for req in dependencies) ==
assert ({str(req) for req in dependencies} ==
{'Werkzeug>=0.7', 'Jinja2>=2.4', 'itsdangerous>=0.21'})

ireq = from_line('ipython==2.1.0')
dependencies = repository.get_dependencies(ireq)
assert set(str(req) for req in dependencies) == {'gnureadline'}
assert {str(req) for req in dependencies} == {'gnureadline'}

ireq = from_line('ipython[notebook]==2.1.0')
dependencies = repository.get_dependencies(ireq)
assert (set(str(req) for req in dependencies) ==
assert ({str(req) for req in dependencies} ==
{'gnureadline', 'pyzmq>=2.1.11', 'tornado>=3.1', 'jinja2'})

ireq = from_line('ipython[notebook,nbconvert]==2.1.0')
dependencies = repository.get_dependencies(ireq)
assert (set(str(req) for req in dependencies) ==
assert ({str(req) for req in dependencies} ==
{'gnureadline', 'pyzmq>=2.1.11', 'tornado>=3.1', 'jinja2', 'pygments', 'Sphinx>=0.3'})


Expand Down
2 changes: 1 addition & 1 deletion tests/test_top_level_editable.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_editable_top_level_deps_preserved(base_resolver, repository, from_edita
repository = _get_repository()
output = base_resolver(input, prereleases=False, repository=repository).resolve()

output = set([p.name for p in output])
output = {p.name for p in output}

# sanity check that we're expecting something
assert output != set()
Expand Down

0 comments on commit 86f72cc

Please sign in to comment.