Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Cython tests for binary wheels #463

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

skirpichev
Copy link
Contributor

Closes #447

@skirpichev
Copy link
Contributor Author

This is an incomplete version so far: MacOS wheels aren't tested yet. Also, probably we should document how users can use bundled libraries for their extensions.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a39f52) 85.51% compared to head (3c86ae8) 85.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          49       49           
  Lines       11691    11691           
  Branches     2211     2211           
=======================================
  Hits         9998     9998           
  Misses       1693     1693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casevh casevh marked this pull request as ready for review January 3, 2024 01:42
@casevh
Copy link
Collaborator

casevh commented Jan 3, 2024

Am I inadvertently blocking progress on this PR?

@skirpichev
Copy link
Contributor Author

Am I inadvertently blocking progress on this PR?

No, that's entirely my fault. Some further progress is in test-wheels-cython2 branch.

I'll try to finish this pr today, sorry for a delay.

@skirpichev skirpichev marked this pull request as draft January 3, 2024 02:00
@skirpichev
Copy link
Contributor Author

Ok, now it works on MacOS too.

@casevh casevh marked this pull request as ready for review January 4, 2024 02:02
@casevh
Copy link
Collaborator

casevh commented Jan 4, 2024

Looks fine. I'll merge the PR and then test with my Windows build process.

@casevh casevh merged commit 95a4ed2 into aleaxit:master Jan 4, 2024
9 checks passed
@skirpichev skirpichev deleted the test-wheels-cython branch January 4, 2024 07:24
@skirpichev
Copy link
Contributor Author

Hmm, this was a draft. This I think that related issue isn't solved: at least this pr lacks documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cython C-API is broken in published wheels (and in the build_wheels.yml CI workflow)
3 participants