-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Cython tests for binary wheels #463
Conversation
This is an incomplete version so far: MacOS wheels aren't tested yet. Also, probably we should document how users can use bundled libraries for their extensions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 49 49
Lines 11691 11691
Branches 2211 2211
=======================================
Hits 9998 9998
Misses 1693 1693 ☔ View full report in Codecov by Sentry. |
6977c03
to
3c86ae8
Compare
Am I inadvertently blocking progress on this PR? |
No, that's entirely my fault. Some further progress is in test-wheels-cython2 branch. I'll try to finish this pr today, sorry for a delay. |
3c86ae8
to
d962582
Compare
Ok, now it works on MacOS too. |
Looks fine. I'll merge the PR and then test with my Windows build process. |
Hmm, this was a draft. This I think that related issue isn't solved: at least this pr lacks documentation. |
Closes #447