Use PyLong_GetSign() #486
Closed
Use PyLong_GetSign() #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
use-pylong-getsign
branch
2 times, most recently
from
724432c
to
32aeb00
Compare
|
Probably, discussion in capi-workgroup/decisions#19 is ended. |
skirpichev
force-pushed
the
use-pylong-getsign
branch
from
9770628
to
a3c4175
Compare
count should be equal to size
skirpichev
force-pushed
the
use-pylong-getsign
branch
from
a3c4175
to
fbf99e6
Compare
|
Should this be merged now and then released as 2.2.0 or should this wait until 2.2.1? |
I don't think so. capi-workgroup/decisions#29 is open. We should wait, see also https://discuss.python.org/t/c-api-working-group-vacancy-again/56167 This pr shouldn't block 2.2 release. I'll just mark it as a draft. |
|
I don't like it, but probably capi-workgroup/decisions#35 API will have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/cpython#116561 and capi-workgroup/decisions#19. I'm not happy with this API and it seems that discussion is ongoing. Maybe it's wise to wait some time...