Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: Disable selected day style #167

Closed
Boehrsi opened this issue Jan 1, 2020 · 4 comments
Closed

Feature proposal: Disable selected day style #167

Boehrsi opened this issue Jan 1, 2020 · 4 comments

Comments

@Boehrsi
Copy link
Contributor

Boehrsi commented Jan 1, 2020

I'm currently using your plugin (btw. it's awesome, really nice work 👍) and I open a new view on tap (detail view for events). Additionally to the new view also the selected day changes, which is fine. But it gets highlighted which isn't need for my use case and confuses some of my users.
I could adjust the style of the selected day with the calendarStyle property, but I don't know how to adjust the style dynamically for weekdays / weekends and so on.
What do you think about a calendarStyle property to disable additional styling of the currently selected day completely?
Something simlar could be also useful for the "today highlighting".
I would propose something like:

calendarStyle: CalendarStyle(
              selectedHighlighting: false,
              todayHighlighting: false,
),

Additional information:

  • table_calendar: ^2.2.1
  • Flutter version: v1.12.13+hotfix.5

PS
Happy new year ;)

@Boehrsi
Copy link
Contributor Author

Boehrsi commented Jan 1, 2020

I just had a look into the code and added a PR. Feedback would be much appreciated.

@aleksanderwozniak
Copy link
Owner

That's a nice idea, I like it :)

aleksanderwozniak added a commit that referenced this issue Jan 4, 2020
…ctedDayHighlighting

Disable selected day / today style #167
@aleksanderwozniak
Copy link
Owner

Version 2.2.2 with your PR has been released

@Boehrsi
Copy link
Contributor Author

Boehrsi commented Jan 5, 2020

Thanks a lot. And thanks for your nice library :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants