Pass along gaze watch parameters so that there is more control over file watching. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2017 12:10
Suggested new version is minor change, non-breaking.
alexgorbatchev
requested changes
Jul 11, 2017
index.js
Outdated
| @@ -16,7 +17,8 @@ function startWatching({ watch, match, exec }, { verbose }) { | |||
| return new Promise(resolve => { | |||
| match = match || [ '**/*' ]; | |||
| const prefix = [ list('watch', watch), list('match', match), list('exec', exec) ].join(' '); | |||
| const gaze = new Gaze(watch); | |||
| console.log(JSON.stringify(options.gazeOptions)); | |||
There was a problem hiding this comment.
Could you please use log() function instead of console.log()? I would like to keep ability to have it completely silent.
There was a problem hiding this comment.
I will remove this completely.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "run-when-changed", | |||
| "version": "2.0.2", | |||
| "version": "2.1.0", | |||
There was a problem hiding this comment.
I can rev the version and create a git tag at the same time when I publish.
There was a problem hiding this comment.
okay, I will move this back..
|
Okay, I have updated the code based on your suggestions.
|
|
Should this pull request be merged? The asked for changes have been made. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case is described in issue #5