-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom request function APIC-126 #1312
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1fd062e:
|
There's no automatic way ,it was still on the todo to infer those types (there should be a way, by calling addMethods at the right moment) but I didn't yet get the time to look into it. |
Are you sure the method should be called |
It's done in Python and for Android, and it's called |
Makes sense. In theory js could still be an outlier, as it usually favours shorter method names, but I'll leave it up to you |
you'll need to update the bundlesize in package.json based on the response in ci still by the way |
I would also favor request as it more discoverable, but if it was already done let's stay consistant and it can conflict in some language as Request is a very basic keyword |
Jira ticket: APIC-126
Adds the
customRequest
function to the search client for all environment, to allows clients to use features that are not yet implemented.I didn't find a way to automatically generate the
algoliasearch/src/builds/*.ts
files, I'm not sure if there is one.