Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): allow insights options to be forwarded to Autocomplete #1904

Merged
merged 8 commits into from
Jun 8, 2023
Merged

feat(api): allow insights options to be forwarded to Autocomplete #1904

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d40e269
Allow insights options to be forwarded to Autocomplete
8bittitan May 30, 2023
9fa7a45
Add autocomplete params to hits for insights
8bittitan May 31, 2023
1faa9d8
Fixes TS errors after Autocomplete update
8bittitan Jun 2, 2023
932cfc5
Bump bundlesize after Autocomplete update
8bittitan Jun 2, 2023
12b08d0
Cleanup checking if insights is active
8bittitan Jun 2, 2023
fc69998
Add documentation for sending events with DocSearch
8bittitan Jun 2, 2023
756b89d
Move insights boolean casting to inside of getSources
8bittitan Jun 6, 2023
d141129
Update packages/docsearch-react/src/DocSearchModal.tsx
8bittitan Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/docsearch-react/src/DocSearchModal.tsx 
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
  • Loading branch information
@8bittitan @francoischalifour
8bittitan and francoischalifour committed Jun 7, 2023
commit d141129ee95f4bc09a972a252a8ecca4118141d5
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/DocSearchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ export function DocSearchModal({
siblingItem.type === 'lvl1' &&
siblingItem.hierarchy.lvl1 ===
item.hierarchy.lvl1
) as InternalDocSearchHit;
) as InternalDocSearchHit | undefined;

if (item.type !== 'lvl1' && potentialParent) {
parent = potentialParent;
Expand Down