Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement suggested params #72

Merged
merged 27 commits into from
Feb 28, 2020
Merged

implement suggested params #72

merged 27 commits into from
Feb 28, 2020

Conversation

mjiang102628
Copy link
Contributor

@mjiang102628 mjiang102628 commented Feb 12, 2020 •
edited
Loading

  • add SuggestedParams object to handle fee, first valid round, last valid round, and genesis hash
  • tests will fail since this is backwards incompatible
    • locally updated tests are passing

@mjiang102628
enable user to specify fee when getting transactions for the split co…
4521884 
…ntract
@mjiang102628
Update template.py
6e00763
@mjiang102628
Update template.py
6e0e021
@mjiang102628
Merge branch 'develop' into michelle/split
8ad2483
@mjiang102628
Update test_unit.py
1345c16
@mjiang102628
fix ratio implementation
3234f89
@mjiang102628
merge from develop
333fa1e
@mjiang102628
flip order of rat_1 and rat_2, use new golden
b3efcbf
@mjiang102628
add get_transaction for HTLC
0121530
@mjiang102628
read receiver from contract in HTLC
6930a7e 
- add checks for transaction fee exceeding max fee
@mjiang102628
Update test_unit.py
09ea8d0
@mjiang102628
Update test_unit.py
e6a5f8f
@mjiang102628
fix encoding bug
f76c971
@mjiang102628
add check for preimage matching hash image
2387417 
- switch from cryptography to pycryptodomex; cryptography library missing keccak256 hash function
@mjiang102628
Update template.py
4bbf251
@mjiang102628
implement txn params
7d821bb
@mjiang102628
fix checks for override values
a6155a7 
- use flat_fee before params if fee not specified
- use first + 1000 before params if last not specified
@mjiang102628
update docstrings to allow None for params argument
51fadd3
@mjiang102628
add SuggestedParams class
7a8984c
@mjiang102628
Update transaction.py
f2ae305
@mjiang102628
merge from develop
6349ba9
@mjiang102628 mjiang102628 marked this pull request as ready for review February 20, 2020 02:46
winder
winder approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, this is a very nice incremental improvement.

EvanJRichard
EvanJRichard approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rotemh
Copy link
Contributor

rotemh commented Feb 25, 2020 •
edited
Loading

What about genesisID? Seems like we lack support of it. It can be optional but I don’t think we should skip it.

@mjiang102628
Copy link
Contributor Author

genesisID is supported; it's in both the SuggestedParams constructor and the Transaction constructor.

@mjiang102628 mjiang102628 merged commit 30ca776 into develop Feb 28, 2020
@mjiang102628 mjiang102628 deleted the michelle/txn-params branch February 28, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder winder approved these changes

@EvanJRichard EvanJRichard EvanJRichard approved these changes

@rotemh rotemh Awaiting requested review from rotemh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjiang102628 @rotemh @winder @EvanJRichard