Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update CMakeLists for AppleClang 15.x Support #360

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: update CMakeLists for AppleClang 15.x Support #360

merged 1 commit into from
Jan 9, 2024

Conversation

faker2048
Copy link
Contributor

Why

The current CMake settings do not specifically address AppleClang 15.x versions, which is needed to handle certain compiler errors.

macos 14.2.1 (m2) version of clang:

message("Compiler ID: ${CMAKE_CXX_COMPILER_ID}")
message("Compiler Version: ${CMAKE_CXX_COMPILER_VERSION}") 

# Compiler ID: AppleClang
# Compiler Version: 15.0.0.15000040

What is changing

Added a condition in CMakeLists.txt to apply the -Wno-unsequenced option specifically for AppleClang 15.x

ChuanqiXu9
ChuanqiXu9 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ChuanqiXu9 ChuanqiXu9 merged commit b3d7658 into alibaba:main Jan 9, 2024
14 checks passed
@faker2048 faker2048 deleted the fix-compiler-error-on-macos branch January 9, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuanqiXu9 ChuanqiXu9 ChuanqiXu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faker2048 @ChuanqiXu9