Skip to content

Commit

Permalink
remove adminPassword in profile
Browse files Browse the repository at this point in the history
  • Loading branch information
2456868764 committed Nov 2, 2023
1 parent cc082df commit 66b18b4
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 10 deletions.
8 changes: 3 additions & 5 deletions pkg/cmd/hgctl/helm/profile.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,15 @@ func (p ProfileGlobal) Validate(install InstallMode) []error {
}

type ProfileConsole struct {
Port uint32 `json:"port,omitempty"`
Replicas uint32 `json:"replicas,omitempty"`
AdminPassword string `json:"adminPassword,omitempty"`
O11yEnabled bool `json:"o11YEnabled,omitempty"`
Port uint32 `json:"port,omitempty"`
Replicas uint32 `json:"replicas,omitempty"`
O11yEnabled bool `json:"o11YEnabled,omitempty"`
}

func (p ProfileConsole) SetFlags(install InstallMode) ([]string, error) {
sets := make([]string, 0)
if install == InstallK8s || install == InstallLocalK8s {
sets = append(sets, fmt.Sprintf("higress-console.replicaCount=%d", p.Replicas))
sets = append(sets, fmt.Sprintf("higress-console.admin.password=%s", p.AdminPassword))
sets = append(sets, fmt.Sprintf("higress-console.o11y.enabled=%t", p.O11yEnabled))
}
return sets, nil
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/hgctl/installer/standalone_agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ func (a *Agent) profileArgs() []string {
fmt.Sprintf("--nacos-password=%s", a.profile.Storage.Password),
fmt.Sprintf("--nacos-username=%s", a.profile.Storage.Username),
fmt.Sprintf("--data-enc-key=%s", a.profile.Storage.DataEncKey),
fmt.Sprintf("--console-password=%s", a.profile.Console.AdminPassword),
fmt.Sprintf("--console-port=%d", a.profile.Console.Port),
fmt.Sprintf("--gateway-http-port=%d", a.profile.Gateway.HttpPort),
fmt.Sprintf("--gateway-https-port=%d", a.profile.Gateway.HttpsPort),
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/hgctl/manifests/profiles/_all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ global:
console:
port: 8080
replicas: 1
adminPassword: admin
o11yEnabled: false

gateway:
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/hgctl/manifests/profiles/k8s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ global:

console:
replicas: 1
adminPassword: admin
o11yEnabled: false

gateway:
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/hgctl/manifests/profiles/local-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ global:

console:
port: 8080
adminPassword: admin

gateway:
httpPort: 80
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/hgctl/manifests/profiles/local-k8s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ global:

console:
replicas: 1
adminPassword: admin
o11yEnabled: true

gateway:
Expand Down

0 comments on commit 66b18b4

Please sign in to comment.