Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The K8s domain name suffix is hard-coded to "cluster.local" #460

Closed
johnlanni opened this issue Aug 2, 2023 · 1 comment
Closed

The K8s domain name suffix is hard-coded to "cluster.local" #460

johnlanni opened this issue Aug 2, 2023 · 1 comment
Assignees
@teijinyer
Labels
area/config

Comments

@johnlanni
Copy link
Collaborator

Why do you need it?

The domain name suffix needs to support configuration.

higress/pkg/ingress/kube/util/util.go

Line 83 in 9b88c6b

return fmt.Sprintf("%s.%s.svc.%s", name, namespace, DefaultDomainSuffix)

@johnlanni johnlanni added type/bug Something isn't working help wanted Extra attention is needed priority/normal area/config and removed type/bug Something isn't working labels Aug 2, 2023
@teijinyer
Copy link
Contributor

I can try to fix it

@CH3CHO CH3CHO removed the help wanted Extra attention is needed label Aug 3, 2023
teijinyer added a commit to teijinyer/higress that referenced this issue Aug 3, 2023
@teijinyer
fix: support configuration domain suffix (alibaba#460)
30e7475
teijinyer added a commit to teijinyer/higress that referenced this issue Aug 3, 2023
@teijinyer
fix: support configuration domain suffix (alibaba#460)
6c0a5a7
teijinyer added a commit to teijinyer/higress that referenced this issue Aug 3, 2023
@teijinyer
fix: support configuration domain suffix (alibaba#460)
302b4ba
teijinyer added a commit to teijinyer/higress that referenced this issue Aug 3, 2023
@teijinyer
fix: set a global variable(alibaba#460)
6950428
teijinyer added a commit to teijinyer/higress that referenced this issue Aug 3, 2023
@teijinyer
fix: set a global variable(alibaba#460)
93180bc
johnlanni added a commit that referenced this issue Aug 7, 2023
@teijinyer @johnlanni
support configuration domain suffix (#460) (#463)
8c206a6 
Co-authored-by: 澄潭 <zty98751@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teijinyer teijinyer

Labels
area/config
Projects
Higress
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CH3CHO @johnlanni @teijinyer