Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove redundant helm charts and add console as a dependency #223

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 2, 2023

Ⅰ. Describe what this PR did

  1. Remove redundant helm charts.
  2. Rename the current higress chart to higress-core
  3. Add a new higress chart and add higress-core and higress-console as its dependencies.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #223 (6720f7a) into main (7e2c039) will increase coverage by 0.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   43.09%   43.54%   +0.45%     
==========================================
  Files          31       31              
  Lines        5038     5038              
==========================================
+ Hits         2171     2194      +23     
+ Misses       2699     2677      -22     
+ Partials      168      167       -1     
Impacted Files Coverage Δ
pkg/bootstrap/server.go 64.12% <0.00%> (+8.77%) ⬆️

@CH3CHO CH3CHO marked this pull request as draft March 2, 2023 02:35
@CH3CHO CH3CHO force-pushed the feat/helm-with-console branch 3 times, most recently from 5dcd8b8 to 0d42636 Compare March 6, 2023 17:27
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@CH3CHO CH3CHO marked this pull request as ready for review March 6, 2023 18:01
@CH3CHO CH3CHO requested a review from johnlanni as a code owner March 6, 2023 18:01
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 7f6b157 into alibaba:main Mar 7, 2023
@CH3CHO CH3CHO deleted the feat/helm-with-console branch March 7, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants