Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split REGISTRY into BUILDER_REGISTRY and REGISTRY #395

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

ESWZY
Copy link
Contributor

@ESWZY ESWZY commented Jun 25, 2023

Ⅰ. Describe what this PR did

As the documentation says, we can

The registry address of the generated image, e.g. example.registry.io/my-name/. Note that the REGISTRY value should end with /.

But in the Makefile, REGISTRY specifies both the registry of builder and the registry of artifact.

For most users, they may not want to set the builder registry and output image registry to be the same, so it is necessary to separate them.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@ESWZY ESWZY requested a review from johnlanni as a code owner June 25, 2023 09:53
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnlanni johnlanni merged commit f327012 into alibaba:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants