-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add higress base image #423
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 40.30% 39.98% -0.33%
==========================================
Files 45 45
Lines 6178 6178
==========================================
- Hits 2490 2470 -20
- Misses 3515 3535 +20
Partials 173 173 |
@fengshunli Please fix the e2e test. |
711d6b3
to
96cc8d0
Compare
@johnlanni approval |
c19e301
to
d3a5e8a
Compare
|
||
|
||
docker-build-base: | ||
docker buildx build --no-cache --platform linux/amd64,linux/arm64 -t ${HUB}/base:${BASE_VERSION} -f docker/Dockerfile.base . --push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用当前的tag来build一个新的base镜像是不是不太合理啊?
8a83403
to
0983b5a
Compare
Signed-off-by: fengshunli <1171313930@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews