Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go mod path in waf plugin #440

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix go mod path in waf plugin #440

merged 1 commit into from
Jul 17, 2023

Conversation

spacewander
Copy link
Contributor

Ⅰ. Describe what this PR did

Use higress's SDK, not its fork.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Only fix the import path

Ⅳ. Describe how to verify it

The CI should pass

Ⅴ. Special notes for reviews

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #440 (08c7a65) into main (81e467b) will decrease coverage by 0.26%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   40.23%   39.98%   -0.26%     
==========================================
  Files          45       45              
  Lines        6151     6178      +27     
==========================================
- Hits         2475     2470       -5     
- Misses       3503     3535      +32     
  Partials      173      173              

see 4 files with indirect coverage changes

@spacewander spacewander marked this pull request as ready for review July 17, 2023 12:27
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnlanni johnlanni merged commit aa17e95 into alibaba:main Jul 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants