Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copyrights on the file header are different. #2873

Closed
KomachiSion opened this issue May 24, 2020 · 0 comments · Fixed by #3048
Closed

The copyrights on the file header are different. #2873

KomachiSion opened this issue May 24, 2020 · 0 comments · Fixed by #3048
Milestone

Comments

@KomachiSion
Copy link
Collaborator

Issue Description

Copyright

Describe what happened (or what feature you want)

The copyrights on the file header are different.

some of are

/*
 * Copyright 1999-2018 Alibaba Group Holding Ltd.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

and others are

/*
 * Copyright (C) 2019 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

I'm nor sure whether have other version copyright.

I think we should unify their year and attribution.

@KomachiSion KomachiSion added kind/code quality kind/discussion Category issues related to discussion kind/proposal labels Jun 5, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Jun 12, 2020
@KomachiSion KomachiSion removed kind/code quality kind/discussion Category issues related to discussion labels Jun 12, 2020
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 12, 2020
@KomachiSion KomachiSion linked a pull request Jun 12, 2020 that will close this issue
5 tasks
chuntaojun added a commit that referenced this issue Jun 12, 2020
[ISSUE #2873] Unified copyright for file header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant