fix-4787 #4802
Merged
fix-4787 #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
approved these changes
Jan 26, 2021
wangweizZZ
reviewed
Jan 27, 2021
| @@ -174,9 +171,6 @@ public static String getIPFromString(String str) { | |||
| Matcher m = ipv4Pattern.matcher(str); | |||
| if (m.find()) { | |||
| result = m.group(); | |||
| if (!isIPv4(result)) { | |||
There was a problem hiding this comment.
这里主要是从数据库url里解析IP地址,ipv4Pattern已经验证了是v4的串了,再验证一次也没意义
wangweizZZ
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4787
根据冒号拆分 "IP(域名):端口" 格式字符串时,移除 isIPv4 的判断.
因为在k8s环境下,这个时候域名可能还没注册上导致域名解析失败. 并且如果域名指向的是IPV6,也会出问题