[struct_pack][feat] support c++17 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poor-circle
force-pushed
the
struct_pack_support_stdcpp17
branch
4 times, most recently
from
79e6e5f
to
caab629
Compare
poor-circle
force-pushed
the
struct_pack_support_stdcpp17
branch
from
ae9d16d
to
bdfa2ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #388
What is changing
Now struct_pack support c++17.
Api break changes: remove struct_pack::serialize_config class and use an uint64_t to instead it, because c++17 don't support struct as non-type template parameter.
In C++17 we don't support user defined continous container, so only std::vector/std::basic_string/std::basic_string_view could enable continous container copy optimize (memcpy).
Example