Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coro_io]fix: std::move used on a local var as return value #490

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[coro_io]fix: std::move used on a local var as return value #490

merged 1 commit into from
Nov 13, 2023

Conversation

scuzqy
Copy link
Contributor

@scuzqy scuzqy commented Nov 13, 2023

Why

Moving local variables as return value interferes with RVO.

This is a common bad practice.

@scuzqy
[coro_io]fix: std::move used on a local var as return value
a390cc1 
Moving local variables as return value interferes with RVO.
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@poor-circle
Copy link
Collaborator

LGTM, thanks!

@poor-circle
Copy link
Collaborator

I will merge it after you sign the CLA.

@scuzqy
Copy link
Contributor Author

scuzqy commented Nov 13, 2023

hi @poor-circle, sign good now. Thx!

@poor-circle poor-circle merged commit 51505c4 into alibaba:main Nov 13, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scuzqy @CLAassistant @poor-circle