Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[struct_pack] improve performance when deserialize vector<pod>/string #506

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[struct_pack] improve performance when deserialize vector<pod>/string #506

merged 1 commit into from
Nov 27, 2023

Conversation

poor-circle
Copy link
Collaborator

Why

add a hacker resize to enhance deserialize std::basic_string/std::vector speed.

What is changing

Now when deserialize string/vector of pod, we won't init the memory when resize the container, which make deserialize faster.

Example

@qicosmos qicosmos self-requested a review November 27, 2023 09:19
qicosmos
qicosmos approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poor-circle poor-circle merged commit 091ce7c into alibaba:main Nov 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qicosmos qicosmos qicosmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poor-circle @qicosmos