Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[struct_pack][fix] set std::bitset as unportable type #522

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

poor-circle
Copy link
Collaborator

@poor-circle poor-circle commented Dec 8, 2023

Why

std::bitset is hard to cross platform between big-endian & little-endian.

What is changing

Set it as unportable type now.

User can define marco STRUCT_PACK_ENABLE_UNPORTABLE_TYPE to enable std::bitset.

Example

#define STRUCT_PACK_ENABLE_UNPORTABLE_TYPE
#include<ylt/struct_pack.hpp>
int main() {
  auto buffer = struct_pack::serialize(std::bitset<114>{});
  return 0;
}

@poor-circle poor-circle merged commit 30cf244 into alibaba:main Dec 8, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant