Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coro_http][improve]Remove shared ptr, improve request ssl #558

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

qicosmos
Copy link
Collaborator

@qicosmos qicosmos commented Jan 3, 2024

Why

simplify request ssl, init_ssl is not necessary:

#ifdef CINATRA_ENABLE_SSL
  std::string uri = "https://cn.bing.com";
  auto data = co_await client.async_get(uri);
  std::cout << data.status << std::endl;
#endif

websocket client no need use shared_ptr any more.

add more examples.

What is changing

Example

@qicosmos qicosmos changed the title [coro_http][improve]Remove shared ptr [coro_http][improve]Remove shared ptr, improve request ssl Jan 3, 2024
@qicosmos qicosmos merged commit 73a0016 into alibaba:main Jan 3, 2024
30 checks passed
@qicosmos qicosmos deleted the remove_shared_ptr branch January 3, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant