export cmake option when developer use CMake FetchContent #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
For example, use the following cmake config
```
include(FetchContent)
FetchContent_Declare(
yalantinglibs
GIT_REPOSITORY https://github.com/alibaba/yalantinglibs.git
GIT_TAG xxx # use the least commit id
GIT_SHALLOW 1 # optional ( --depth=1 )
)
FetchContent_MakeAvailable(yalantinglibs)
add_executable(demo main.cpp)
target_link_libraries(demo PRIVATE yalantinglibs)
```
you can use `cmake -DENABLE_STRUCT_PACK_UNPORTABLE_TYPE=ON ..`,
the option `ENABLE_STRUCT_PACK_UNPORTABLE_TYPE=ON` will be used when building yalantinglibs
PikachuHyA
force-pushed
the
export_cmake_options
branch
from
68a1d91
to
c0e48cf
Compare
|
Code Coverage Report |
|
Code Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
see #590
What is changing
When use CMake FetchContent
the cmake/config.cmake is included.
all compilation definitions and linking library will be handled automatically.
Example
For example, use the following cmake config
you can use
cmake -DENABLE_STRUCT_PACK_UNPORTABLE_TYPE=ON .., the optionENABLE_STRUCT_PACK_UNPORTABLE_TYPE=ONwill be used when building yalantinglibs