-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[coro_http_server] use std::error_code instead of std::errc as result in coro_http_server. fix singleton servercrash when destructed. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poor-circle
changed the title
[coro_http_server]do some fix
[coro_http_server] use std::error_code instead of std::errc as result in coro_http_server. fix singleton servercrash when
Apr 7, 2024
poor-circle
changed the title
[coro_http_server] use std::error_code instead of std::errc as result in coro_http_server. fix singleton servercrash when
[coro_http_server] use std::error_code instead of std::errc as result in coro_http_server. fix singleton servercrash when destructed.
Apr 7, 2024
Code Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Close #654
Close #655
use std::error_code instead of std::errc for server.async_start/start;
init easylog singleton in server's construct function to make sure easylog life time is longer than server;
fix a bug of reverse proxy.
What is changing
Example