Feature/allow specifying custom splunkjsonformatter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋 .
I found your NuGet package when looking for a package that was better at coping with Splunk server-side failures, and stumbled upon your durable version of the Splunk sink for Serilog. Thanks for making it!
When test-driving the NuGet package I found that the fields ended up with different names in Splunk. For instance, @Level instead of Level, and no Properties.* before custom properties.
The solution for me would be to specify a custom
ITextFormatter, so that I can take care of serialization myself (or lift the formatter from theSerilog.Sinks.Splunkpackage).This PR allows for that extension. I opted to leave the custom formatter out, since people can find it freely on Serilog.Sinks.Splunk.