Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security (and user-testing) contribution type #127

Merged

Conversation

jakebolam
Copy link
Collaborator

@jakebolam jakebolam commented Dec 31, 2018

What:
Add Security contribution type, as mentioned in all-contributors/all-contributors#106 and implemented in all-contributors/all-contributors#107

Also added user-testing as introduced as part of https://github.com/kentcdodds/all-contributors/pull/97/files

Why:
All contributors!

How:
Me

Checklist:

  • Documentation
  • Tests - N/A
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files          19       19           
  Lines         446      446           
  Branches       79       79           
=======================================
  Hits          261      261           
  Misses        154      154           
  Partials       31       31
Impacted Files Coverage Δ
src/util/contribution-types.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ade2d7...2d1d885. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 89bac0f into all-contributors:master Jan 2, 2019
@jakebolam jakebolam deleted the feature/add-security-type branch January 2, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants