Minor UI improvements #1892
Open
Minor UI improvements #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moscicky
reviewed
Sep 16, 2024
| @@ -43,7 +43,8 @@ export const dummyTopicFormValidator = { | |||
| ownerSource: [required()], | |||
| owner: [required()], | |||
| contentType: [required()], | |||
| retentionTimeDuration: [required(), min(0), max(7)], | |||
| retentionTimeDurationDays: [required(), min(0), max(7)], | |||
| retentionTimeDurationHours: [required(), min(0), max(7)], | |||
There was a problem hiding this comment.
in hermes-console/src/composables/topic/use-form-topic/useFormTopic.ts we used max of 24 and different mins, is this intentional ?
moscicky
previously approved these changes
Sep 16, 2024
szczygiel-m
force-pushed
the
minor_ui_improvements_august_2024
branch
from
62c0b68
to
d93066d
Compare
moscicky
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done in this PR?