This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix test-install by moving tests into module #1232
Merged
Merged
Changes from 91 commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
cf8caa5
Prevent tests from being installed as module by setup.py
nelson-liu 95784af
Bulk move tests
nelson-liu 369b044
Add PROJECT_ROOT, TESTS_ROOT, FIXTURES_ROOT
nelson-liu c79d3c8
Fix fine_tune_test
nelson-liu 26def09
Fix dry run tests
nelson-liu 2d81aae
Fix broken import in elmo_test
nelson-liu 380f947
Fix elmo tests
nelson-liu a7955ef
Fix evaluate test
nelson-liu ac949e7
Fix imports in adaptive/bucket/epoch_tracking_bucket iterator tests
nelson-liu 7917d4a
Move ROOT variables out of setUp
nelson-liu fa1adf6
Make cached_path work with Path
nelson-liu 96fbc0c
Fix server_flask_test
nelson-liu 3f07136
Edit pytest.ini for new path
nelson-liu 402ecc5
remove tests from manifest.in
nelson-liu c334b7f
fix lint in fine_tune_test
nelson-liu b07b216
Fix lint in server_flask_test
nelson-liu b1752dc
Add mypy.ini to ignore tests
nelson-liu 7a5cf23
Fix pylint command in verify.py
nelson-liu bba7250
Use pathlib in server_flask_test
nelson-liu 5257ddb
Fix make_vocab test
nelson-liu 0b99d7e
Fix commands.main_test
nelson-liu dab4575
Fix predict test
nelson-liu 80af620
Fix train_test
nelson-liu 4e29992
Make file_utils use pathlib
nelson-liu 5dc6a19
Fix file_utils test
nelson-liu 2a88224
Fix params test
nelson-liu c731494
Fix test_util
nelson-liu 36a506c
Fix conll2003_dataset_reader
nelson-liu b2d7411
Fix coref_reader_test
nelson-liu dde498d
Fix winobias reader test
nelson-liu 84fc4e6
fix ontonotes_test
nelson-liu a75c674
Fix language_modeling_dataset
nelson-liu caac10c
Fix nlvr_test
nelson-liu aed512e
Fix penn_tree_bank_reader
nelson-liu 54b42e2
Fix squad_test
nelson-liu dc56c10
Fix triviaqa_test
nelson-liu df33454
Fix seq2seq_test
nelson-liu b006aea
Fix sequence_tagging_test
nelson-liu c840400
Fix SNLI reader test
nelson-liu 17a62b0
Fix srl_dataset_reader
nelson-liu 26d1d81
Fix SST dataset reader tests
nelson-liu 00f4a37
Fix wikitables_test
nelson-liu 8079bd8
Change directory to module root when testing model so fixture paths work
nelson-liu b64f249
Fix archival test
nelson-liu 1e58031
Fix BCN
nelson-liu e7a5e35
Fix constituency parser tests
nelson-liu e6a02af
Fix coref_test
nelson-liu 12dd555
Fix crf_tagger_test
nelson-liu ac0ff22
Fix decomposable_attention_test
nelson-liu 96f47e7
Fix simple_seq2seq_test
nelson-liu 19e5af3
Fix bidaf_ensemble_test
nelson-liu de5dde1
Fix bidaf_test
nelson-liu b6c86e3
Fix nlvr_coverage_semantic_parser
nelson-liu d6ea1b7
Fix nlvr_direct_semantic_parser_test
nelson-liu 32d6d5d
Fix wikitables_erm_semantic_parser_test
nelson-liu e276f86
Fix wikitables_mml_semantic_parser_test
nelson-liu 7ca33b0
Fix semantic_role_labeler test
nelson-liu c28877e
Add simple_tagger_test
nelson-liu d401a1e
Fix fine_tune_test that i broke
nelson-liu 35963d1
Fix vocabulary_test
nelson-liu 4df7dc9
Fix elmo_token_embedder_test
nelson-liu 36df899
Fix embedding_test
nelson-liu 3c08b8a
Fix nlvr_world_test
nelson-liu a1439e1
Fix wikitables_world_test
nelson-liu dc4ec71
Fix world_test
nelson-liu ba98ac2
Fix server_simple_test
nelson-liu 3ed0e7d
Fix predictors.bidaf_test
nelson-liu b564459
Fix predictors.constituency_parser
nelson-liu 36d4df7
Fix predictors.coref_test
nelson-liu 48265f2
Fix decomposable_attention test
nelson-liu 1906755
Fix nlvr_parser_test
nelson-liu b11c4f6
Fix predictors.isimple_seq2seq_test
nelson-liu a50e9d2
Fix srl_test
nelson-liu 38b1589
Fix wikitables_parser_test
nelson-liu a27847a
Fix optimizer_test
nelson-liu c873879
Fix trainer test
nelson-liu 3b15536
Fix wikitables_accuracy_test
nelson-liu 977d33b
Add srl-eval.pl to tools, use it in tests
nelson-liu 8cd7e11
Make SEMPRE better clean up after itself
nelson-liu 6347bff
Reword test_install command
nelson-liu 24b19b7
Fix lint
nelson-liu 8602e89
Add tests to ignored modules in check_docs
nelson-liu dd65b29
Remove copy tests from dockerfile
nelson-liu fae7143
Rename project_root to module_root in test_install
nelson-liu a963695
Fix lint
nelson-liu f123ec8
skip notebook tests in allennlp test-install --run-all, since we're r…
nelson-liu 0d4d000
Further cleanup of files leftover by SEMPRE
nelson-liu 309cf5f
Remove accidentally committed evalb binary
nelson-liu 5cddce8
Wildcard exclude custom_extensions from check_docs.py
nelson-liu 92f9d82
Merge branch 'master' into rework_test_install
nelson-liu 00c166c
Merge branch 'master' into rework_test_install
nelson-liu e01ba27
Remove accidental print in wikitables_accuracy_test
nelson-liu 6324d62
Remove srl-eval.pl from scripts
nelson-liu 852afb1
Merge branch 'master' into rework_test_install
nelson-liu 65f51a3
Merge branch 'master' into rework_test_install
nelson-liu d478ccd
Add comment explaining test_install_test
nelson-liu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelgrus does this
Union
, and all thestr(path)
calls in this PR change how you feel aboutPath
?