-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
In the grand scheme of things I think we should deprecate the crf_tagger tutorial and replace it with a polished version of the AcademicPaperClassifier tutorial |
Why remove the laziness how-to? |
@matt-gardner all it does is index into a larger tutorial (which unfortunately hasn't been listed on our website--see allenai/allennlp-website#45). |
But that's kind of the point - a "how-to" is a "please just tell me how to do this" document. The tutorial is "teach me about the library", with explanations for things. They accomplish different purposes. |
I didn't find it particularly helpful, and asked Joel if he wanted to keep it around--he didn't. |
This reverts commit dd53d9a.
The place where it is helpful is if you just want to make your iterator lazy, without having to read a long tutorial about AllenNLP's philosophy around laziness. I suspect you didn't find it helpful because you haven't been in that position before. I think having a bunch of how-tos that just give quick information is a good idea, and I'm in favor of keeping it. |
I disagree that we should keep it, but I reverted the commit so I could merge this PR. |
* Amend installation instructions. * Update allennlp usage. * Small improvements.
Small tweaks to our tutorials, some of which are quite out of date. I might make some larger changes to reduce redundancy in a follow-on PR.