Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Tutorial cleanup #1260

Merged
merged 5 commits into from
May 22, 2018
Merged

Tutorial cleanup #1260

merged 5 commits into from
May 22, 2018

Conversation

schmmd
Copy link
Member

@schmmd schmmd commented May 22, 2018

Small tweaks to our tutorials, some of which are quite out of date. I might make some larger changes to reduce redundancy in a follow-on PR.

@joelgrus
Copy link
Contributor

In the grand scheme of things I think we should deprecate the crf_tagger tutorial and replace it with a polished version of the AcademicPaperClassifier tutorial

@matt-gardner
Copy link
Contributor

Why remove the laziness how-to?

@schmmd
Copy link
Member Author

schmmd commented May 22, 2018

@matt-gardner all it does is index into a larger tutorial (which unfortunately hasn't been listed on our website--see allenai/allennlp-website#45).

@matt-gardner
Copy link
Contributor

But that's kind of the point - a "how-to" is a "please just tell me how to do this" document. The tutorial is "teach me about the library", with explanations for things. They accomplish different purposes.

@schmmd
Copy link
Member Author

schmmd commented May 22, 2018

I didn't find it particularly helpful, and asked Joel if he wanted to keep it around--he didn't.

@matt-gardner
Copy link
Contributor

The place where it is helpful is if you just want to make your iterator lazy, without having to read a long tutorial about AllenNLP's philosophy around laziness. I suspect you didn't find it helpful because you haven't been in that position before. I think having a bunch of how-tos that just give quick information is a good idea, and I'm in favor of keeping it.

@schmmd
Copy link
Member Author

schmmd commented May 22, 2018

I disagree that we should keep it, but I reverted the commit so I could merge this PR.

@schmmd schmmd merged commit 622ea1b into allenai:master May 22, 2018
gabrielStanovsky pushed a commit to gabrielStanovsky/allennlp that referenced this pull request Sep 7, 2018
* Amend installation instructions.

* Update allennlp usage.

* Small improvements.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants