This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Migrate gevent's wsgi to pywsgi #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gevent 1.0a1 was released in 2011, wsgi is just an alias for pywsgi. In version 1.3 wsgi is completely removed, causing allennlp to break. For more info check http://www.gevent.org/api/gevent.wsgi.html Test plan: run scripts/verify.py on trunk, all test pass.
joelgrus
approved these changes
May 24, 2018
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
Since gevent 1.0a1 was released in 2011, wsgi is just an alias for pywsgi. In version 1.3 wsgi is completely removed, causing allennlp to break. For more info check http://www.gevent.org/api/gevent.wsgi.html Test plan: run scripts/verify.py on trunk, all test pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gevent 1.0a1 was released in 2011, wsgi is just an alias for pywsgi.
In version 1.3 wsgi is completely removed, causing allennlp to break.
For more info check http://www.gevent.org/api/gevent.wsgi.html
Test plan:
run scripts/verify.py on trunk, all test pass.