Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

add user contributed models blurb #1306

Merged
merged 5 commits into from
May 30, 2018
Merged

Conversation

DeNeutoy
Copy link
Contributor

image

@DeNeutoy
Copy link
Contributor Author

DeNeutoy commented May 29, 2018

Thoughts? Super easy to add, it's our most visible platform. @joelgrus, @matt-gardner @schmmd

@joelgrus
Copy link
Contributor

are we that interested in adding third-party models to the library itself? I thought when we discussed this we decided we'd rather link out to other people's repos, except in rare cases

@matt-gardner
Copy link
Contributor

That's a great idea! 👍

@matt-gardner
Copy link
Contributor

@joelgrus, yes, I think we'd generally want to link to other libraries, instead of forcing consistency with our codebase, but I also think we should try to host others' demos even without them contributing their code. We need to think about how exactly to do this (e.g., we have a separate demo repo that has third-party code as submodules, and puts everything together), but I think it's something we should do.

@joelgrus
Copy link
Contributor

sure, I just meant that the message as written suggests that we want to add the models to the library itself

@matt-gardner
Copy link
Contributor

Fair enough, we could probably word it better. But I definitely think that having a link right there on the demo with a message at least similar to what Mark has is a spectacular idea.

@DeNeutoy DeNeutoy requested a review from schmmd May 29, 2018 23:45
@schmmd
Copy link
Member

schmmd commented May 30, 2018

@DeNeutoy love it! I think your existing wording is fine--although we certainly won't add every model people send us to our demo.

Although "link out" is the default, but depending on the quality of the model we should be open to adding them to the library itself.

@DeNeutoy DeNeutoy merged commit 26e7f41 into allenai:master May 30, 2018
@DeNeutoy DeNeutoy deleted the user-models-demo branch May 30, 2018 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants