-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
DeNeutoy
commented
May 29, 2018
Thoughts? Super easy to add, it's our most visible platform. @joelgrus, @matt-gardner @schmmd |
are we that interested in adding third-party models to the library itself? I thought when we discussed this we decided we'd rather link out to other people's repos, except in rare cases |
That's a great idea! 👍 |
@joelgrus, yes, I think we'd generally want to link to other libraries, instead of forcing consistency with our codebase, but I also think we should try to host others' demos even without them contributing their code. We need to think about how exactly to do this (e.g., we have a separate demo repo that has third-party code as submodules, and puts everything together), but I think it's something we should do. |
sure, I just meant that the message as written suggests that we want to add the models to the library itself |
Fair enough, we could probably word it better. But I definitely think that having a link right there on the demo with a message at least similar to what Mark has is a spectacular idea. |
@DeNeutoy love it! I think your existing wording is fine--although we certainly won't add every model people send us to our demo. Although "link out" is the default, but depending on the quality of the model we should be open to adding them to the library itself. |