Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

small doc fix #4508

Merged
merged 2 commits into from
Jul 31, 2020
Merged

small doc fix #4508

merged 2 commits into from
Jul 31, 2020

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Jul 24, 2020

Closes #4494

@epwalsh epwalsh requested a review from dirkgr July 24, 2020 20:35
dirkgr
dirkgr approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes tests I'm fine with it, but I have found that I get many problems with circular imports from imports that use the big parent modules instead of the detailed child modules.

@matt-gardner matt-gardner merged commit 54e5c83 into master Jul 31, 2020
@matt-gardner matt-gardner deleted the doc-fix branch July 31, 2020 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] One line change in the comments
3 participants
@epwalsh @dirkgr @matt-gardner