This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
automatically find local open port in distributed training #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
suggested changes
Oct 7, 2020
allennlp/commands/train.py
Outdated
| master_port = distributed_params.pop("master_port", 29500) | ||
| if master_addr in ("127.0.0.1", "0.0.0.0", "localhost"): | ||
| # If running locally, we can automatically find an open port if one is not specified. | ||
| master_port = distributed_params.pop("master_port", common_util.find_open_port()) |
There was a problem hiding this comment.
This will run find_open_port() before it tries to read the port from the config. I think we should not run port discovery at all if we don't have to.
dirkgr
approved these changes
Oct 7, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4666