This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Docker builds for other CUDA versions, improve CI #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
changed the title
dirkgr
reviewed
Nov 16, 2020
|
|
||
| AllenNLP releases Docker images to [Docker Hub](https://hub.docker.com/r/allennlp/) for each release. For information on how to run these releases, see [Installing using Docker](#installing-using-docker). | ||
|
|
||
| ### Building a Docker image |
There was a problem hiding this comment.
I just moved it into the "Installing via Docker" section.
| # Only run this for releases on the main repo, not forks. | ||
| if: github.repository == 'allenai/allennlp' && github.event_name == 'release' | ||
| # Only run this for releases. | ||
| if: github.event_name == 'release' |
There was a problem hiding this comment.
Why did all of these if statements change?
There was a problem hiding this comment.
We checked if github.repository == 'allenai/allennlp' above, so it was redundant to have that again.
dirkgr
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request from our conversation here: #4793 (comment). This makes it so we'll build Docker images for both CUDA 10.2 and CUDA 11.0. These will be published as
allennlp/allennlp:v1.2.1-cuda10.2andallennlp/allennlp:v1.2.1-cuda11.0, respectively. We will still also provide alatesttag which for now will default to the CUDA 10.2 image for consistency with PyTorch.This also merges our two GH Actions workflows (
.github/workflows/master.ymland.github/workflows/pull_request.yml) into a single one:.github/workflows/ci.yml.I still have a couple things to do:
pull_request.ymlandmaster.ymlworkflows. Could just call itci.yml.